Skip to content

apk: format install_if fields without brackets - #2193

Open
officialasishkumar wants to merge 1 commit into
chainguard-dev:mainfrom
officialasishkumar:apk-format-install-if
Open

apk: format install_if fields without brackets#2193
officialasishkumar wants to merge 1 commit into
chainguard-dev:mainfrom
officialasishkumar:apk-format-install-if

Conversation

@officialasishkumar

Copy link
Copy Markdown

Summary

  • format APKINDEX and installed DB install_if fields as space-separated values instead of Go slice strings
  • update generated image fixtures and publish digest expectations for the byte-level metadata change

Fixes #2059

Test plan

  • go test ./pkg/apk/...
  • go test ./...
  • git diff --check
  • go mod tidy && git diff --exit-code -- go.mod go.sum

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
@coreydaley-cg

Copy link
Copy Markdown
Contributor

The fix is right and matches how D: and p: are already written. Two things to land it: rebase onto main and regenerate the golden fixtures, since the installed database bytes change, and sign the commit, which is the only red check. Say so if either is a hassle and a maintainer can re-land it with you as co-author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ill-formed package index emitted

2 participants